Make insert attachment buttom easy to click #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Feb 28, 2022
src/components/card/Description.vue
Outdated
Comment on lines
252
to
255
| flex-shrink: 1; | ||
| overflow: scroll; | ||
| max-height: 50vh; | ||
| min-height: 50vh; |
There was a problem hiding this comment.
I think it might even be better if we just remove any height specification and also the overflow scroll, as currently we have two scrollbars with that:
Removing the overflow also seems to fix the tooltip flickering:
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
bug/make-insert-attachment-button-clickable
branch
from
35eeebc
to
6040172
Compare
juliusknorr
approved these changes
Mar 2, 2022
delete-merged-branch
bot
deleted the
bug/make-insert-attachment-button-clickable
branch
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
This was referenced Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
TODO
Checklist