Handle description shortening more gracefully #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Mar 17, 2022
juliusknorr
commented
- Avoid trying to cut of fields that are not there are reported in Long activity subject parameters may cause errors #3649
- Move the logic to the actual event creating method
- Add some more test cases for the scenario and try to improve the related ActivityManagerTest cases a bit
vinicius73
reviewed
Mar 17, 2022
juliusknorr
force-pushed
the
bugfix/3649
branch
from
4a802b6
to
3ab53d9
Compare
vinicius73
approved these changes
Mar 21, 2022
juliusknorr
force-pushed
the
bugfix/3649
branch
from
3ab53d9
to
ff2df1f
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/3649
branch
from
ff2df1f
to
48db989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.