Properly check for the stack AND setting board permissions #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
8 tasks
|
So it seems to work in the backend and there is no error reported anymore, but I have to reload the page to see my edit? |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/stack-update-check
branch
from
7387e21
to
86d3de2
Compare
|
No the edit is applied right away, at least I cannot see any issue when testing here. |
|
Just tried again on this PR and it seems to be "one edit behind" |
|
But since this PR is php only it should be unrelated |
nickvergessen
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #3541 where the the boardId was taken to check for stack permissions. To properly check this we need to extend the permission checks to validate if the board provided in the boardId is also accessible by the user.
Steps to reproduce:
Before:
403
After:
works again
Fixes #3633