-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CardDetail serialization model #3782
Conversation
LGTM; But, what do you think about renaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good approach I think to move the representation logic out of the actual Db entity layer. I'd be fine with the Model naming as well as its a common term here 👍
@Raudius Mind to squash the commits a bit (especially the different cs fix ones)? |
bffedf1
to
ce0de07
Compare
Signed-off-by: Raul <raul@nextcloud.com>
… model Signed-off-by: Raul <raul@nextcloud.com>
Signed-off-by: Raul <raul@nextcloud.com>
Signed-off-by: Raul <raul@nextcloud.com>
Signed-off-by: Raul <raul@nextcloud.com>
Signed-off-by: Raul <raul@nextcloud.com>
ce0de07
to
9fca104
Compare
I copied the idea (and name) from the Collectives app. So I think I will leave it as |
Summary
Adds
CardDetail
+BoardSummary
models which centralises serialisation of Card database models. This will be useful for the upcoming changes in the overview page (#2807) which will require attaching additional information to the Card (namely: board name) as it will not need to be added in multiple parts of the code.Checklist