Switch to 'markdown-it-task-checkbox' for rendering of task lists

[q-wertz]

Signed-off-by: q-wertz clemens.sonnleitner@web.de

• Resolves: Checklists break (markdown) styled text in description field #2109
• Target version: master

Summary

As suggested by @https://github.com/hrk I gave it a shot and tried to use the library markdown-it-task-checkbox instead of markdown-it-task-lists.

• Not sure if some of the features that were added to markdown-it-task-lists are needed. I tried to get the same classnames for ulClass and liClass but e.g. the enabled class to the <li> elements (which has been introduced with v2.0.0 of markdown-it-task-lists) cannot be set (but did not find any references in the Deck app which seem to require this).
• Also not sure whether PR Fix for issue #3637 #3833 has any side effects on this.

TODO

• Double check code validity (I'm neither an experienced web developer nor do I have deep insights in Deck or Nextcloud)
• Test

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included -> Don't think additional specific tests are required
• Documentation (manuals or wiki) has been updated or is not required

[juliusknorr]

Tested and works and the library also seem sane to use, thanks a lot for this 👍

[juliusknorr]

Can you maybe also push the package-lock.json updates after running npm install --save markdown-it-task-checkbox While I could rebase through the web UI it seems I cannot push from my local machine to your branch.

[q-wertz]

👍

There were quite some warnings and the package-lock.json changed a lot (due to the rebasing?)...

$ npm install --save markdown-it-task-checkbox
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'deck@1.8.0-beta.0',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/axios@1.10.0',
npm WARN EBADENGINE   required: { node: '^14', npm: '^7' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/eslint-config@8.0.0',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/stylelint-config@2.1.2',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/vue@5.3.1',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/webpack-vue-config@5.1.0',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v18.3.0', npm: '8.6.0' }
npm WARN EBADENGINE }
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

added 1609 packages, and audited 1610 packages in 47s

208 packages are looking for funding
  run `npm fund` for details

13 vulnerabilities (3 moderate, 10 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

[juliusknorr]

/backport to stable24

[backportbot-nextcloud]

The backport to stable24 failed. Please do this backport manually.

[q-wertz]

Is this also backported to NC 23?

[q-wertz]

Is there any information when this will be in any stable version? 😅