Prevent opening card and applyLabelFilter on card drag end #3916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
fix/2594/click-event-on-drag-end
branch
from
035252f
to
9d3f09f
Compare
|
PHP tests skipped as no change affected PHP -> Merging |
|
@eneiluj Just a quick hint, using |
|
/backport to stable24 |
|
/backport to stable23 |
|
/backport to stable22 |
This was referenced Jul 12, 2022
Yeah i always think "what if we don't want to close the issue now" but you're right, most of the time the PR closes the issue 😁. |
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #2594
Problem: A click event is triggered on the element we drag (when dragging a card) when it's dropped.
This issue was mentioned in vue-smooth-dnd: kutlugsahin/vue-smooth-dnd#50 but no solution/fix was provided.
I can't find another way to solve this.
Suggested solution: Thanks to drag-start and drag-end events, we know if we are currently dragging a card or not. We pass this information to the cards. The
applyLabelFilterandopenCardmethods of the CardItem component don't do anything when the card is being dragged.