Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CalDAV integration performance #3982

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Improve CalDAV integration performance #3982

merged 2 commits into from
Aug 17, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 17, 2022 •
edited
Loading

  • Avoid querying each card when getting the calendars only
  • Avoid fetching archived cards for calendars

Should resolve #3542
Fixes #3981

@juliusknorr
Avoid querying each card when getting the calendars only
eb65468 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Avoid fetching archived cards for calendars
9171ffc 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added this to the 1.8.0 (Nextcloud 25) milestone Aug 17, 2022
miaulalala
miaulalala approved these changes Aug 17, 2022
View reviewed changes
Copy link

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PVince81 PVince81 merged commit de0dc27 into master Aug 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the performance/dav branch August 17, 2022 14:13
@juliusknorr
Copy link
Member Author

/backport to stable24

@juliusknorr
Copy link
Member Author

/backport to stable23

This was referenced Aug 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@Raudius Raudius Awaiting requested review from Raudius

Assignees
No one assigned
Labels
3. to review performance 🚀
Projects
None yet
Milestone
1.8.0 (Nextcloud 25)
Development

Successfully merging this pull request may close these issues.

Performance issue when cards are fetched during calendar propfind loading deck in calendar slow
3 participants
@juliusknorr @miaulalala @PVince81