Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live updates 🎉 #4273

Merged
merged 6 commits into from
Feb 21, 2023
Merged

live updates 🎉 #4273

merged 6 commits into from
Feb 21, 2023

Conversation

alangecker
Copy link
Collaborator

@alangecker alangecker commented Nov 22, 2022 •
edited
Loading

Summary

out

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@alangecker alangecker mentioned this pull request Nov 22, 2022
Merged
4 tasks
@matbgn
Copy link

matbgn commented Jan 3, 2023

@alangecker You are just sooooo amazing thanks a lot for your incredible job on #3876!

Just absolutely exited to see your achievement here also! And as promised as soon as you're near to release I will reward your job again.

Words are just out of my mind, so I will keep it simple : THANK YOU!

@alangecker alangecker force-pushed the live-updates branch 2 times, most recently from a529c57 to 0b28240 Compare January 4, 2023 14:02
@alangecker
Copy link
Collaborator Author

I guess it is now also ready for a review 🙂

@matbgn
Copy link

matbgn commented Jan 4, 2023

@juliushaertl could you let run the CI to see what need to be done there?

@juliusknorr
Copy link
Member

@alangecker I invited you as a contributor to the repo so follow up pushes should not require approval any longer.

@juliusknorr juliusknorr self-requested a review January 5, 2023 11:27
@alangecker
Copy link
Collaborator Author

@juliushaertl ui, thanks! that helps a lot and probably also reduces your work load 🙂

@matbgn
Copy link

matbgn commented Jan 10, 2023

The functionality is there and all the checks in the CI are green. I mean, it's time for a reward!

I really hope that either @juliushaertl or @marcelklehr will have the time to review it soon, but for myself it's time to act 😄

Again many thanks @alangecker and wish you an happy new year!

@matbgn
Copy link

matbgn commented Jan 23, 2023

Hi everyone,

I know we all have many things on the plate, but we are eagerly waiting on this MR for our staff.

How do you see the next steps @juliushaertl and @marcelklehr?

Wish you all the best

@juliusknorr
Copy link
Member

I've blocked some time to review and test this next week.

@marcelklehr
Copy link
Member

Wow, I totally missed this in my inbox so far. Sorry!

marcelklehr
marcelklehr reviewed Feb 3, 2023
View reviewed changes
src/sessions.js
const currentBoardId = store.state.currentBoard?.id
if (body.boardId !== currentBoardId) return

store.dispatch('loadStacks', currentBoardId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having checked myself: Would it be possible to only update the changed card?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be definitely nice if we could just fetch the one updated card

@marcelklehr
Copy link
Member

Code looks good IMHO. Will try to find time to test next week.

@matbgn
Copy link

matbgn commented Feb 13, 2023

Kindly reminder 😸

juliusknorr
juliusknorr approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works like a charm 👍

Thanks for this awesome contribution. We can merge this from my side if rebased and the conflict is resolved.

@matbgn
Copy link

matbgn commented Feb 14, 2023

Amazing!!! 🍾

If @alangecker fixes the very last details in the next few days, when do you plan to release the public version for Nextcloud users? If I'm not mistaken, #3876 is still not available with the last version 1.8.3, is it?

@juliusknorr
Copy link
Member

Since this is a larger feature it will become part of the next minor release 1.9 which is scheduled together with Nextcloud 26. Backports to older versions only happen for bug fixes unfortunately.

@alangecker
Copy link
Collaborator Author

thanks to all of you ♥

there are somehow now some tests failing.
I'll have a look into them during the next days and got already a draft for fetching only the updated card on the disk 🙂

@juliusknorr juliusknorr mentioned this pull request Feb 15, 2023
Merged
7 tasks
@juliusknorr
Copy link
Member

juliusknorr commented Feb 15, 2023 •
edited
Loading

I'll check the psalm errors as they also happen on the main branch. I've noticed a small bug when trying to share a board, the fix was straight forward but maybe you can put that into your branch directly so we have the changes together: 49d424e

@juliusknorr
Copy link
Member

psalm checks should also pass now after a rebase :)

@small1

This comment was marked as off-topic.

Sign in to view
@juliusknorr

This comment was marked as off-topic.

Sign in to view
@alangecker @juliusknorr
live updates for boards
322ee92 
Signed-off-by: chandi Langecker <git@chandi.it>
@alangecker @juliusknorr
live updates: listen for stack and board changes
41d8867 
Signed-off-by: chandi Langecker <git@chandi.it>
@alangecker @juliusknorr
live updates: remove deleted cards with loadStacks() and not just app…
2e6b20d 
…end them

Signed-off-by: chandi Langecker <git@chandi.it>
@alangecker @juliusknorr
chore(psalm): adding missing events for annotation
437f5c9 
Signed-off-by: chandi Langecker <git@chandi.it>
@alangecker @juliusknorr
style(sessionlist): less incisive borders
c03d067 
Signed-off-by: chandi Langecker <git@chandi.it>
@alangecker @juliusknorr
test(unit): fix tests, mostly due to missing boardId's, which are now…
b4eece8 
… required for event emitting

Signed-off-by: chandi Langecker <git@chandi.it>
@juliusknorr
Copy link
Member

I took the liberty to rebase and push so we can get this in for the first pre-release for Nextcloud 26.

@juliusknorr
Copy link
Member

Let's get this in 🚀

@juliusknorr juliusknorr merged commit 0af2fd4 into nextcloud:main Feb 21, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 7, 2023

🎉🎉🎉🎉🎉

@mario-neuhold mario-neuhold mentioned this pull request Aug 9, 2023
Closed
@joshtrichards joshtrichards mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr left review comments

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contents synchronisation / Live update for changes
6 participants
@alangecker @matbgn @juliusknorr @marcelklehr @small1 @szaimen