Improve reference provider and add reference widgets #4422
Conversation
| parent::__construct('', $card->getTitle(), $board->getTitle() . ' » ' . $stack->getTitle(), $urlGenerator->linkToRouteAbsolute('deck.page.index') . '#/board/' . $board->getId() . '/card/' . $card->getId(), 'icon-deck'); | ||
| parent::__construct( | ||
| $urlGenerator->getAbsoluteURL( | ||
| $urlGenerator->imagePath(Application::APP_ID, 'card.svg') |
There was a problem hiding this comment.
Wondering if this icon is a better match:
https://pictogrammers.com/library/mdi/icon/card-bulleted-outline/
There was a problem hiding this comment.
👍 We had the same idea. It's the one I'm using in the reference widget.
julien-nc
force-pushed
the
enh/noid/discoverable-searchable-ref-provider
branch
3 times, most recently
from
df6ec69
to
0859480
Compare
|
Seems the composer ocp packages are not automatically bumped for deck anymore since we renamed the default branch to main. Filed nextcloud/office#25 for this but feel free to just update that composer package manually for this pr. |
|
Integration test failures seem related to search of comments ;) |
I changed a search provider ID and didn't adjust the tests... All good now. |
julien-nc
force-pushed
the
enh/noid/discoverable-searchable-ref-provider
branch
from
6b5bb6d
to
b2f01d1
Compare
|
Rebased on main |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…n ref provider Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ReferenceProvider (no widgets but resolving) Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…ents Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/discoverable-searchable-ref-provider
branch
from
60e911c
to
f775728
Compare
|
It does not sound like an issue to me 😁. Should we disable/ignore this psalm check? |
|
Yep, let's ignore that for this PR. |
delete-merged-branch
bot
deleted the
enh/noid/discoverable-searchable-ref-provider
branch
The card reference provider is now discoverable and searchable. It supports all the available search providers (boards+cards and comments).
There is a minor flaw (i mean just a weird aspect) of the reference provider design. In this case the provider used to resolve and render cards is supporting all the search providers so we can have one single provider entry in the link picker. I'm fine with that but that can be confusive.
New reference widgets for boards and comments.
There would be a lot of factorization to be done between the card and the comment widget. Just waiting we decide what should be their respective content before factorizing.
Also worth mentioning: I changed the CommentService a bit to make it possible to get a comment from a cardId and a commentId. This lead to a small refactoring of the service.
TODO: