Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bring back overdue column by removing faulty condition #4660

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: Bring back overdue column by removing faulty condition #4660

merged 1 commit into from
May 10, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 9, 2023 •
edited
Loading

Fixes #4627

@juliusknorr
fix: Bring back overdue column by removing faulty condition
d028728 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/backport to stable26

@juliusknorr juliusknorr mentioned this pull request May 9, 2023
Closed
datenangebot
datenangebot approved these changes May 9, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is okay for me, so approved.
But whats the reason for the change in nc26 or was is a general bug?
Do we want to show the column even if there are no cards?

@cypress
Copy link

cypress bot commented May 9, 2023

Passing run #880 ↗︎

0 15 0 0 Flakiness 0

Details:

Merge d028728 into c318916...
Project: Deck Commit: fa799483a8 ℹ️
Status: Passed Duration: 02:41 💡
Started: May 9, 2023 7:56 PM Ended: May 9, 2023 7:59 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

This was an oversight when I adapted the frontend bits for the performance optimizations done in #3793, therefore only stable26. We probably want some more sophisticated empty content behaviour but that is a larger topic with the design mockups we have at #2807, so something for a different time. ;)

@juliusknorr juliusknorr merged commit b9c8e8f into main May 10, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/overdue branch May 10, 2023 05:36
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Nextcloud 26 removes "Overdue" column for "Upcoming cards"
2 participants
@juliusknorr @datenangebot