-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to native date picker #4668
Conversation
1 failed test on run #1435 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
1e4e968
to
48d8f1c
Compare
@nextcloud/designers for visual review, screenshots are in the description 🙏 |
Super nice! Only some small changes:
|
I'm not sure about that. The radio button only be selected as long as the day hasn't changed or the end of the day hasn't been reached. I feel without a radio button it is more logical as a single time action to set the date accordingly.
I like the idea, unfortunately there seems to be no way to properly localize the short form in terms that the order might be different (in Germany it would be 26. Aug for example) If accepting that we always have the same order no matter of which locale to use, then we could do that, otherwise I'd rather leave it out. |
48d8f1c
to
5ae067f
Compare
9bde832
to
ce0e8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one minor suggestion.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
ce0e8e9
to
7f36dd2
Compare
Summary
Move to native datetime picker component as the old one has quite some issues especially with accessibility.
Shortcuts are now adapted to match the implementation of the reminders feature in files/talk.
Checklist