feat: Add devcontainer and update dev docs #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #912 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
juliusknorr
force-pushed
the
enh/devcontainer
branch
from
a6645ae
to
d691c8d
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/devcontainer
branch
from
39ba47d
to
352e66f
Compare
juliusknorr
requested review from
max-nextcloud,
luka-nextcloud,
datenangebot and
DaphneMuller
|
🤯 This is really mind blowing. Thanks for looking into it. I imagine this will lower the barrier to entry a LOT! |
max-nextcloud
approved these changes
May 15, 2023
There was a problem hiding this comment.
I had a quick look at the code and the docs. Seems good to me.
Also tried it out by clicking the branch name on top of this PR and then opening it in a code space. Took a while to spin up and compile the JS but then it was working just fine.
Still trying to grasp the implications of this... :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add devcontainer setup to have a fully ready dev environment on github codespaces available
Update development docs to clarify the different options