Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create new card from smart picker #4969

Merged
merged 5 commits into from
Aug 9, 2023
Merged

feat: create new card from smart picker #4969

merged 5 commits into from
Aug 9, 2023

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Aug 4, 2023
@cypress
Copy link

cypress bot commented Aug 4, 2023 •
edited
Loading

Passing run #1237 ↗︎

0 15 0 0 Flakiness 0

Details:

Merge 3b09608 into ba56687...
Project: Deck Commit: bd54aede53 ℹ️
Status: Passed Duration: 02:44 💡
Started: Aug 9, 2023 11:58 AM Ended: Aug 9, 2023 12:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member

juliusknorr commented Aug 4, 2023 •
edited by luka-nextcloud
Loading

As discussed during the call:

  • Put card title to the top
  • Board picker and list picker side by side
  • Make CardSidebarTabDetails sections reusable
    • Migrate CreateNewCardCustomPicker to use a boilerplate card object as well instead of individual duedate/selectedLabels/.. data attributes
    • Extract tag multiselect section with icon from CardSidebarTabDetails to a sepeate component TagSelector
      - those get a card object passed <DueDateSelector :card="card" />
      • Use the TagSelector in CardSidebarTabDetails
      • Use the TagSelector in CreateNewCardCustomPicker
    • Do the same for AssignmentSelector, DueDateSelector
    • Use Description component in CreateNewCardCustomPicker

As the last step:

  • Merge CreateCardDialog and CreateNewCardCustomPicker (only use the new one with all options)
    • Old create card dialog can just have a prop to show the "Card was added to the board" info or emit the event for the smart picker

@luka-nextcloud luka-nextcloud force-pushed the feature/create-new-card-from-smart-picker branch from e470afe to a26f868 Compare August 7, 2023 06:25
@luka-nextcloud luka-nextcloud force-pushed the feature/create-new-card-from-smart-picker branch from a26f868 to c5ec5a3 Compare August 7, 2023 16:00
@luka-nextcloud luka-nextcloud force-pushed the feature/create-new-card-from-smart-picker branch from c5ec5a3 to 51b852e Compare August 8, 2023 15:54
@luka-nextcloud
Copy link
Contributor Author

@juliushaertl I've done the following things:

  • add icons before selectors input
  • add prop autofocus for title input
  • pass size param 'normal' while calling registerCustomPickerElement()
  • fix closing create card modal

@juliusknorr juliusknorr force-pushed the feature/create-new-card-from-smart-picker branch from 51b852e to 46342d1 Compare August 9, 2023 09:02
luka-nextcloud and others added 3 commits August 9, 2023 13:25
@luka-nextcloud @juliusknorr
feat: create new card from smart picker
12217af 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr
fix: Also detect reference to simple card urls
5910d8a 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Load editor on reference pickers for card create dialog
16063af 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the feature/create-new-card-from-smart-picker branch from 46342d1 to 16063af Compare August 9, 2023 11:25
@juliusknorr
fix: Add missing scss file
5db743c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member

@luka-nextcloud FYI I pushed a bit more polishing, to reuse styles and also use the same component for creating files from the talk app

Latest state:

Screenshot 2023-08-09 at 13 35 00

@juliusknorr
chore: Add LoadEditor event to psalm stubs
3b09608 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit 96081a5 into main Aug 9, 2023
25 checks passed
@juliusknorr juliusknorr deleted the feature/create-new-card-from-smart-picker branch August 9, 2023 12:02
@juliusknorr
Copy link
Member

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 9, 2023
Merged
@juliusknorr juliusknorr mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new deck card from smart picker
2 participants
@luka-nextcloud @juliusknorr