Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cypress tests for create new deck card #5025

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@cypress
Copy link

cypress bot commented Aug 14, 2023

Passing run #1297 ↗︎

0 17 0 0 Flakiness 0

Details:

Merge 369de2d into cfeda55...
Project: Deck Commit: d1888d82f7 ℹ️
Status: Passed Duration: 02:10 💡
Started: Aug 14, 2023 7:30 AM Ended: Aug 14, 2023 7:32 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cy.get('.modal__card .ProseMirror').contains('/index.php/apps/deck/card/').should('be.visible')

cy.visit(`/apps/deck/#/board/${boardId}`)
cy.reload()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luka-nextcloud Can you file a follow up ticket and look into calling a board refresh in the vuex store in this case? Would be nice to show the card directly without needing to reload

async refreshBoard({ commit, dispatch }, boardId) {

@juliusknorr juliusknorr merged commit 87cc013 into main Aug 14, 2023
13 checks passed
@juliusknorr juliusknorr deleted the feature/add-tests-create-new-deck-card branch August 14, 2023 07:44
@juliusknorr
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress tests for new create card dialog / smart picker
2 participants