Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remember last board, list for new card dialog #5046

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@cypress
Copy link

cypress bot commented Aug 22, 2023

Passing run #1348 ↗︎

0 17 0 0 Flakiness 0

Details:

Merge e03e57e into 56a0025...
Project: Deck Commit: ebbc4e0ce8 ℹ️
Status: Passed Duration: 01:36 💡
Started: Aug 24, 2023 1:45 PM Ended: Aug 24, 2023 1:46 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment regarding the local storage keys. Otherwise this looks good. Maybe you can have a look a the cypress test failure, that looks like it could be related

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud luka-nextcloud force-pushed the feature/preselect-board-list-for-new-card-dialog branch from 0d3a7a6 to e03e57e Compare August 24, 2023 13:41
@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Please check again.

@juliusknorr juliusknorr merged commit 2bf339f into main Aug 24, 2023
13 checks passed
@juliusknorr juliusknorr deleted the feature/preselect-board-list-for-new-card-dialog branch August 24, 2023 13:47
@juliusknorr
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember last board/list for new card dialog
2 participants