Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check both card reference url patterns #5262

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: Check both card reference url patterns #5262

merged 1 commit into from
Nov 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 7, 2023 •
edited
Loading

The browser URL patterns were unused

Fixes that and adds a phpunit test

@juliusknorr
fix: Check both card reference url patterns
08d30bb 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

/backport to stable27

mejo-
mejo- approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, kudos for the test ❤️

@juliusknorr juliusknorr merged commit de4ad24 into main Nov 7, 2023
28 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/card-reference-url branch November 7, 2023 10:23
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @mejo-