Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue triage fix collection #5280

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Issue triage fix collection #5280

merged 11 commits into from
Nov 13, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 12, 2023 •
edited
Loading

Collecting fixes while going through the issue tracker. Mostly small but partly annoying things and I felt we can keep CI time sane by just having them in one PR.

Reviews best on the individual commits.

@juliusknorr
fix: Expose card actions in the card menu (fix #3180)
5818027 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Use full card menu everywhere (fix #3993)
265c4c4 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Detect end of the activity responses (fix #3395)
ee1a3e0 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Add title with absolute date time to activity (fix #4508, fix #2122
342d9be 
)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title bugfix/multiple Issue triage fix collection Nov 12, 2023
@juliusknorr juliusknorr changed the base branch from main to fix/design November 12, 2023 11:27
@juliusknorr juliusknorr force-pushed the bugfix/multiple branch 2 times, most recently from 2f7fb91 to ee408ba Compare November 12, 2023 11:33
@juliusknorr juliusknorr force-pushed the bugfix/multiple branch 4 times, most recently from 1a5d8b8 to 3ddc687 Compare November 13, 2023 07:54
@juliusknorr
fix: Disable dragging archived cards (fix #3271)
c876e87 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Hide unavailable card menu entries for archived card view
6f6d628 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Use localCompare to sort labels
f24123c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: More fitting click target for title editing
bd122b0 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Always load proper dashboard js
8eb2f48 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Set fixed height for card modal (fix #4296)
587b44f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Make sure to always update card description when navigating awayfix
29d5913 
fix #5254
fix #2705

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr marked this pull request as ready for review November 13, 2023 08:03
mejo-
mejo- approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes all look sensible to me 👍

Base automatically changed from fix/design to main November 13, 2023 14:16
@juliusknorr juliusknorr merged commit 3ef2bce into main Nov 13, 2023
29 checks passed
@juliusknorr juliusknorr deleted the bugfix/multiple branch November 13, 2023 14:16
@juliusknorr
Copy link
Member Author

/backport to stable27

elhananjair
elhananjair reviewed Nov 13, 2023
View reviewed changes
src/components/ActivityList.vue
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @juliushaertl does the change you made fix loading all data from the past? or just make the status to be 200 and stop the spin?
The reason is it stops loading old activities I have made to the card and starts spinning after showing recent activities.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand your question. The 304 status code indicates that the end of the activity list has been reached in which case we stop fetching on scroll. The bug that was fixed caused an error once reaching the end leading to the spinner never hiding.

Copy link

@elhananjair elhananjair Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand your question. The 304 status code indicates that the end of the activity list has been reached in which case we stop fetching on scroll. The bug that was fixed caused an error once reaching the end leading to the spinner never hiding.

In my case, it is not showing me anything on the timeline tab for some cards especially if there was no activity made to the card. Is it normal behavior?
image

Actually, I noticed there is an info shown on the details of the card [the time the card was created and modified]. I just couldn't be sure if the application is showing each activity since the cards were created, some cards might have been created a long time ago.
image

This is might not related to this fix but I am seeing this notification for cards that have been completed a while ago.
image

@ericloyd
Copy link

Is there any way to force install this into 27.1.3?

@juliusknorr juliusknorr mentioned this pull request Nov 13, 2023
Merged
@juliusknorr
Copy link
Member Author

This is being backported for the next maintenance release of deck in #5286

@juliusknorr juliusknorr mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elhananjair elhananjair elhananjair left review comments

@mejo- mejo- mejo- approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees
No one assigned
Labels
2. developing bug
Projects
📝 Office team
Archived in project
Milestone
No milestone
4 participants
@juliusknorr @ericloyd @mejo- @elhananjair