Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid throwing errors if no token provided on close #5284

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: Avoid throwing errors if no token provided on close #5284

merged 1 commit into from
Nov 13, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 13, 2023 •
edited
Loading

  • Avoid throwing type errors if no token was provided in the backend
  • Only trigger closeSessionViaBeacon if a token is still available

@juliusknorr
fix: Avoid throwing errors if no token provided on close
4e10f80 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit 030ad0f into main Nov 13, 2023
29 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/no-token-session branch November 13, 2023 13:03
@solracsf solracsf mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @nickvergessen