Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add debounce to update due date #5458

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: Add debounce to update due date #5458

merged 1 commit into from
Jan 15, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 12, 2024

Fix #5398

Not perfect but for now a quick improvement.

We could save only when leaving the input or closing the modal but that might have the risk to not save a due date unless we do larger changes to combine that with autosaving after some time and block closing the browser window on unsaved changes.

@nickvergessen
Copy link
Member

We could save only when leaving the input or closing the modal but that might have the risk to not save a due date unless we do larger changes to combine that with autosaving after some time and block closing the browser window on unsaved changes.

Yeah I think it's an okay middle ground

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit ba47597 into main Jan 15, 2024
26 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/5398 branch January 15, 2024 10:07
@juliusknorr
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing a 0 in the date picker removes the due date
3 participants