Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/undo delete cards and stacks #557

Merged
merged 10 commits into from
Aug 15, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2018

Closes #259

@ghost
Copy link
Author

ghost commented Jul 28, 2018

@juliushaertl

The drone ci is still failing with the branch pulled into the repo.

@ghost
Copy link
Author

ghost commented Jul 28, 2018

@juliushaertl
Is there a helper for relative time?

@juliusknorr juliusknorr force-pushed the feature/undo-delete-cards-and-stacks branch from da9b463 to f869cc0 Compare July 28, 2018 09:48
@juliusknorr juliusknorr added this to the 0.5.0 milestone Jul 28, 2018
@juliusknorr
Copy link
Member

@LemonAndroid I took the liberty to rebase the branch to current master. Tests run fine now, except for the failures.

It would be awesome if you could go though the commits and add a sign-off message, so that the CI is happy. 😉 I have written down some instructions on how to do that here: #512 (comment) You basically just need to change the HEAD~2 to match the proper base commit of the branch.

Is there a helper for relative time?

There are some angular filters for this:

app.filter('relativeDateFilter', function() {

@juliusknorr
Copy link
Member

@ghost
Copy link
Author

ghost commented Aug 5, 2018

@juliushaertl Why do the travis tests pass but the dron tests do not?

@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #557 into master will decrease coverage by 1.07%.
The diff coverage is 59.67%.

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   80.19%   79.12%   -1.08%     
==========================================
  Files          46       46              
  Lines        1601     1643      +42     
==========================================
+ Hits         1284     1300      +16     
- Misses        317      343      +26

@ghost
Copy link
Author

ghost commented Aug 5, 2018

Two more bugs to squash:

  • Creating a card, adding labels to it, deleting it and restoring it => labels gone temporarily

Presumption is: How labels are rendered for existing and new labels is different.

  • Deleteing a card with labels and reloading the page, then restoring it => labels are only shown when clicking on the card

@ghost
Copy link
Author

ghost commented Aug 5, 2018

@juliushaertl Should codacy not complain now, I consider this done now.

@ghost ghost requested a review from juliusknorr August 5, 2018 20:38
@ghost ghost force-pushed the feature/undo-delete-cards-and-stacks branch 2 times, most recently from 0c5e5e1 to d14bfa0 Compare August 5, 2018 20:52
@ghost ghost requested a review from philippe-levan August 10, 2018 00:57
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

cards: softdelete done; undo delete wip

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

show deleted cards in board settings sidebar wip

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

CardMapper#findDeleted: fix bug in entity property assigning

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

card undo delete done, styling still wip

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

fix Codacy findings

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

stack soft delete done

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

stack undo delete done

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

stack undo: code review remarks and fixes

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

stack undo delete: serve cards with deleted and delete actions

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

stack, cards undo delete: codacy

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

card undo delete: 526#discussion_r204501758, refactoring

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

card, stack undo delete: code review fixes #1

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

undo card, stack delete: show deleted stacks name in deleted card listing

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Stack,Card undo delete: Test Fix 2

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Card, Stack undo delete: Test fix 3

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Card,Stack undo delete: Test fix 4

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Stack, Card undo delete: Relative time in deleted entity listings

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Card, Stack undo delete: Test Fix 5

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Test Fix 6

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

Test Fix 7

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>

fix codacy

Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
@juliusknorr juliusknorr force-pushed the feature/undo-delete-cards-and-stacks branch from d14bfa0 to 241a654 Compare August 15, 2018 18:33
@juliusknorr
Copy link
Member

Great work @LemonAndroid Thank you very much for this enhancement.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr merged commit a3a70f6 into master Aug 15, 2018
@juliusknorr juliusknorr deleted the feature/undo-delete-cards-and-stacks branch August 15, 2018 18:52
@juliusknorr juliusknorr mentioned this pull request Oct 8, 2018
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants