-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/undo delete cards and stacks #557
Conversation
The drone ci is still failing with the branch pulled into the repo. |
@juliushaertl |
da9b463
to
f869cc0
Compare
@LemonAndroid I took the liberty to rebase the branch to current master. Tests run fine now, except for the failures. It would be awesome if you could go though the commits and add a sign-off message, so that the CI is happy. 😉 I have written down some instructions on how to do that here: #512 (comment) You basically just need to change the HEAD~2 to match the proper base commit of the branch.
There are some angular filters for this: deck/js/filters/dateFilters.js Line 28 in 24f4f84
|
@LemonAndroid Please also have a look at https://app.codacy.com/app/juliushaertl/deck/pullRequest?prid=1963741 |
@juliushaertl Why do the travis tests pass but the dron tests do not? |
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 80.19% 79.12% -1.08%
==========================================
Files 46 46
Lines 1601 1643 +42
==========================================
+ Hits 1284 1300 +16
- Misses 317 343 +26 |
Two more bugs to squash:
Presumption is: How labels are rendered for existing and new labels is different.
|
@juliushaertl Should codacy not complain now, I consider this done now. |
0c5e5e1
to
d14bfa0
Compare
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> cards: softdelete done; undo delete wip Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> show deleted cards in board settings sidebar wip Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> CardMapper#findDeleted: fix bug in entity property assigning Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> card undo delete done, styling still wip Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> fix Codacy findings Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> stack soft delete done Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> stack undo delete done Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> stack undo: code review remarks and fixes Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> stack undo delete: serve cards with deleted and delete actions Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> stack, cards undo delete: codacy Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> card undo delete: 526#discussion_r204501758, refactoring Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> card, stack undo delete: code review fixes #1 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> undo card, stack delete: show deleted stacks name in deleted card listing Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Stack,Card undo delete: Test Fix 2 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Card, Stack undo delete: Test fix 3 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Card,Stack undo delete: Test fix 4 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Stack, Card undo delete: Relative time in deleted entity listings Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Card, Stack undo delete: Test Fix 5 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Test Fix 6 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> Test Fix 7 Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info> fix codacy Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
Signed-off-by: Manuel Arno Korfmann <manu@korfmann.info>
d14bfa0
to
241a654
Compare
Great work @LemonAndroid Thank you very much for this enhancement. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Closes #259