Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sharing): list accounts with matches in email #6471

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(sharing): list accounts with matches in email #6471

merged 1 commit into from
Nov 20, 2024

Conversation

max-nextcloud
Copy link
Contributor

@max-nextcloud max-nextcloud commented Nov 4, 2024 •
edited
Loading

  • Target version: main

Summary

  • List email addresses in sharing dialog.
  • Show users with matches in the email address.

NcSelect filters the options based on matches in label and subname.

Todo

  • Write more verbose commit message.
  • Add cypress test to prevent regressions.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation is not required

@stefan-niedermann stefan-niedermann marked this pull request as ready for review November 4, 2024 09:01
@stefan-niedermann stefan-niedermann marked this pull request as draft November 4, 2024 09:01
@max-nextcloud max-nextcloud self-assigned this Nov 13, 2024
@max-nextcloud
fix(sharing): list accounts with matches in email
3e4bf0e 
* Show users with matches in the email address.
* List email addresses in sharing dialog.

`NcSelect` filters the options based on matches in `label` and `subname`.
By using the email address as a subname we ensure
options with a matching email address are shown.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud marked this pull request as ready for review November 18, 2024 14:52
grnd-alt
grnd-alt approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works great. Code's clean 🎉

@juliusknorr juliusknorr merged commit 4da6a42 into main Nov 20, 2024
31 checks passed
@juliusknorr juliusknorr deleted the fix/share-with-email branch November 20, 2024 09:16
@juliusknorr
Copy link
Member

/backport to stable30

@juliusknorr
Copy link
Member

/backport to stable29

@juliusknorr
Copy link
Member

/backport to stable28

@backportbot backportbot bot mentioned this pull request Nov 20, 2024
Merged
This was referenced Nov 20, 2024
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees

@max-nextcloud max-nextcloud

Labels
3. to review bug
Projects
📝 Office team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-nextcloud @juliusknorr @grnd-alt