Clean up code, move values to Style.qml.

Signed-off-by: Camila <hello@camila.codes>
nextcloud · Jun 27, 2022 · cca2420 · cca2420
1 parent 20037fa
commit cca2420
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/src/gui/tray/ActivityItem.qml b/src/gui/tray/ActivityItem.qml
@@ -87,8 +87,9 @@ MouseArea {
             active: root.isChatActivity && root.isTalkReplyPossible && model.messageSent === ""
             visible: root.isTalkReplyOptionVisible
 
+            Layout.preferredWidth: Style.talkReplyTextFieldPreferredWidth
+            Layout.preferredHeight: Style.talkReplyTextFieldPreferredHeight
             Layout.leftMargin: Style.trayListItemIconSize + activityContent.spacing
-            Layout.preferredHeight: root.isTalkReplyOptionVisible ? implicitHeight : 0
 
             sourceComponent: TalkReplyTextField {
                 onSendReply: {

diff --git a/src/gui/tray/TalkReplyTextField.qml b/src/gui/tray/TalkReplyTextField.qml
@@ -17,15 +17,13 @@ Item {
         root.sendReply(replyMessageTextField.text);
     }
 
-    height: 30
-    width: 250
-
     TextField {
         id: replyMessageTextField
 
+        height: Style.talkReplyTextFieldPreferredHeight
+
         anchors.fill: parent
-        topPadding: 4
-        rightPadding: sendReplyMessageButton.width
+
         visible: model.messageSent === ""
 
         color: Style.ncTextColor
@@ -42,9 +40,11 @@ Item {
         }
 
         Button {
-            id: sendReplyMessageButton  
-            width: 32
+            id: sendReplyMessageButton
+
+            width: Style.talkReplyTextFieldPreferredWidth * 0.12
             height: parent.height
+
             opacity: 0.8
             flat: true
             enabled: replyMessageTextField.text !== ""
@@ -53,8 +53,6 @@ Item {
 
             icon {
                 source: "image://svgimage-custom-color/send.svg" + "/" + Style.menuBorder
-                width: 38
-                height: 38
                 color: hovered || !sendReplyMessageButton.enabled? Style.menuBorder : UserModel.currentUser.accentColor
             }
 

diff --git a/theme/Style/Style.qml b/theme/Style/Style.qml
@@ -73,6 +73,9 @@ QtObject {
 
     property int activityLabelBaseWidth: 240
 
+    property int talkReplyTextFieldPreferredHeight: 34
+    property int talkReplyTextFieldPreferredWidth: 250
+
     property int activityItemActionPrimaryButtonMinWidth: 100
     property int activityItemActionSecondaryButtonMinWidth: 80