Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color tray menu header according to theming of active account #4173

Closed
jancborchardt opened this issue Jan 13, 2022 · 2 comments · Fixed by #4237
Closed

Color tray menu header according to theming of active account #4173

jancborchardt opened this issue Jan 13, 2022 · 2 comments · Fixed by #4237
Assignees
Labels
1. to develop design enhancement enhancement of a already implemented feature/code feature: ☁️ system tray System tray icon and menu.

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jan 13, 2022

Tray menu header could reflect theming color of the currently selected account (like in Android for the primary color).
This would help a lot in distinguishing which account is currently selected.

We need to make sure this uses the same algorithm as on web, like if the primary color is very bright, the icons need to be dark, and we need to double-check if it looks good for extremes like white and black as theming colors.

(Leftover part from #877 )

@jancborchardt jancborchardt added 1. to develop design enhancement enhancement of a already implemented feature/code feature: ☁️ system tray System tray icon and menu. labels Jan 13, 2022
@AndyScherzinger
Copy link
Member

@tobiasKaminsky might be able to give some pointers to Android's java implementation of the theming/fallback coloring logic to port over to desktop.

@claucambra claucambra self-assigned this Jan 28, 2022
@tobiasKaminsky
Copy link
Member

https://github.com/nextcloud/android/blob/57b2a8ef1a60fbfa8331b045ca49f0e60d34eb28/src/main/java/com/owncloud/android/utils/theme/ThemeColorUtils.java#L50

Is where we compute/get our color from.

@jancborchardt can you point us to the server side part, so we can check if the some algorithm is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop design enhancement enhancement of a already implemented feature/code feature: ☁️ system tray System tray icon and menu.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants