Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for server color theming #4237

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add support for server color theming #4237

merged 1 commit into from
Mar 16, 2022

Conversation

claucambra
Copy link
Collaborator

This PR adds support for accent colouring pulled from the server's set colour.

Screenshots in light and dark colours:

image

image

image

@claucambra claucambra self-assigned this Feb 1, 2022
@claucambra claucambra linked an issue Feb 2, 2022 that may be closed by this pull request
Color tray menu header according to theming of active account #4173
Closed
@camilasan
Copy link
Member

This fixes #4173

@jancborchardt
Copy link
Member

That looks great @claucambra! Just a small detail: The border around both the avatar status icon and the folder sync status icon should be the same color as the header background.

Currently it's slightly off for the avatar status, seems lighter color, very visible with red theming and the light red border around it. And the folder sync status has a white border. Both should be theming color (Nextcloud blue by default).

Otherwise all good!

@claucambra
Copy link
Collaborator Author

That looks great @claucambra! Just a small detail: The border around both the avatar status icon and the folder sync status icon should be the same color as the header background.

Currently it's slightly off for the avatar status, seems lighter color, very visible with red theming and the light red border around it. And the folder sync status has a white border. Both should be theming color (Nextcloud blue by default).

Otherwise all good!

Thanks, this has been fixed now:

image

@claucambra claucambra force-pushed the feature/accent-color branch 2 times, most recently from d3780f5 to a678d53 Compare February 4, 2022 11:19
mgallien
mgallien requested changes Feb 7, 2022
View reviewed changes
src/gui/tray/Window.qml
width: Style.folderStateIndicatorSize + 2
height: width
anchors.centerIn: parent
color: openLocalFolderButton.hovered ? "white" : "transparent"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a constant from the existing singleton for the color names

src/libsync/theme.h Show resolved Hide resolved
src/gui/tray/usermodel.cpp Outdated Show resolved Hide resolved
jancborchardt
jancborchardt approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super @claucambra! :) 👍 on the design

@claucambra claucambra requested a review from mgallien March 9, 2022 08:45
mgallien
mgallien reviewed Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small last comment and we can merge !!!

src/libsync/capabilities.cpp Outdated Show resolved Hide resolved
@claucambra
Copy link
Collaborator Author

a small last comment and we can merge !!!

Thanks, addressed it

@mgallien
Copy link
Collaborator

@claucambra can you clean up commits history ?

@claucambra
Add support for server color theming by using server color as accent
f585b8b 
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

13.6% 13.6% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 6faf754 into master Mar 16, 2022
@claucambra claucambra deleted the feature/accent-color branch March 16, 2022 14:46
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4237-f585b8bd489444eed07fa86535a6835b780f237b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.5.0 milestone Mar 16, 2022
@jancborchardt jancborchardt mentioned this pull request Mar 17, 2022
Closed
@jancborchardt jancborchardt linked an issue Mar 17, 2022 that may be closed by this pull request
Appling Theming Settings on Desktop Client #3002
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Color tray menu header according to theming of active account Appling Theming Settings on Desktop Client
6 participants
@claucambra @camilasan @jancborchardt @mgallien @nextcloud-desktop-bot @allexzander