Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: String uses only placeholders #7095

Closed
rakekniven opened this issue Sep 10, 2024 · 5 comments · Fixed by #7096
Closed

i18n: String uses only placeholders #7095

rakekniven opened this issue Sep 10, 2024 · 5 comments · Fixed by #7096

Comments

@rakekniven
Copy link
Member

rakekniven commented Sep 10, 2024

Is this meant to be translated?

allStatusStrings += tr("%1: %2").arg(folder->shortGuiLocalPath(), folderMessage);

Reported at Transifex.

Git blame brings me to @nilsding @mgallien

@nilsding
Copy link
Member

my thought was that other translations might have a need to reorder that. if there's no need for that I can change that to a plain QString too.

@rakekniven
Copy link
Member Author

The idea of reordering is good, but there is no comment on the meaning of the placeholders.
Is this about timestamps? Or files/folders?

@nilsding
Copy link
Member

It's the folder to be synced, followed by a status message (e.g. Syncing 25MB (3 minutes left), Waiting to start syncing., Last sync was successful.)

@rakekniven
Copy link
Member Author

Ok. Please see https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#provide-context-hints-for-translators and add you example as a comment.
This comment will appear at Transifex and help the translators. Nearly no one is searching/reading source code.

@nilsding
Copy link
Member

got it, will add an example comment :)

nilsding added a commit to nilsding/desktop that referenced this issue Sep 10, 2024
Resolves nextcloud#7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien pushed a commit to nilsding/desktop that referenced this issue Sep 12, 2024
Resolves nextcloud#7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
backportbot bot pushed a commit that referenced this issue Sep 13, 2024
Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
claucambra pushed a commit that referenced this issue Sep 24, 2024
Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants