Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the make_universal.py script more verbose for easier debugging #4501

Merged
merged 1 commit into from
May 11, 2022
Merged

Make the make_universal.py script more verbose for easier debugging #4501

merged 1 commit into from
May 11, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented May 6, 2022 •
edited
Loading

Small PR that fixes some typos and adds more console output to the make_universal.py script that creates our universal ARM/x86 macOS app bundles, which will help with debugging when things go awry

@claucambra claucambra self-assigned this May 6, 2022
@claucambra claucambra force-pushed the bugfix/verbose-make-universal branch 5 times, most recently from a88e422 to 70156a1 Compare May 11, 2022 10:27
@claucambra @mgallien
Make the make_universal.py script more verbose, make it easier to und…
c9d5929 
…erstand what is happening

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/verbose-make-universal branch from 70156a1 to c9d5929 Compare May 11, 2022 12:33
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4501-c9d592968c82d87d857696e59b5cd02fb93c8d21-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

@claucambra claucambra merged commit 3ec9c00 into master May 11, 2022
@claucambra claucambra deleted the bugfix/verbose-make-universal branch May 11, 2022 13:57
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 11, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan