if an exclude file is deleted, skip it and remove it from internal list #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.5 |
camilasan
approved these changes
May 13, 2022
allexzander
reviewed
May 16, 2022
| if (file.exists() && file.open(QIODevice::ReadOnly)) { | ||
| loadExcludeFilePatterns(basePath, file); | ||
| if (!file.exists()) { | ||
| excludeFileIt = excludeFiles.erase(excludeFileIt); |
There was a problem hiding this comment.
@matthieugallien All this seems complicated. Can't you just loop through _excludeFiles and remove non-existing exclude files before looping them for loadExcludeFilePatterns(basePath, file);? This will double the loop, but, will improve readability.
mgallien
force-pushed
the
bugfix/syncExcludeLstCanBeRemoved
branch
from
da9e3bd to
e12572d
Compare
allexzander
approved these changes
May 16, 2022
mgallien
force-pushed
the
bugfix/syncExcludeLstCanBeRemoved
branch
2 times, most recently
from
c75e79d to
1357ef6
Compare
|
/backport to stable-3.5 |
claucambra
approved these changes
May 16, 2022
ignore files can be removed: not an error so adjust tests Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/syncExcludeLstCanBeRemoved
branch
from
1357ef6 to
5f6277b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
AppImage file: Nextcloud-PR-4519-5f6277b3ee70ac5668d8421486401524e3d5c364-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com