Explicitly ask user for notification authorisation on launch (macOS) #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
reviewed
May 18, 2022
|
/backport to stable-3.5 |
|
/backport to stable-3.4 |
mgallien
approved these changes
May 18, 2022
|
@claucambra please do not forget to clean history and make DCO check happy |
claucambra
force-pushed
the
bugfix/macos-notifications-permission
branch
from
4d41b86 to
380d4ca
Compare
allexzander
reviewed
May 18, 2022
allexzander
approved these changes
May 18, 2022
|
@claucambra Approved, but see my comment |
claucambra
force-pushed
the
bugfix/macos-notifications-permission
branch
from
380d4ca to
6d0f095
Compare
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/macos-notifications-permission
branch
from
6d0f095 to
a2cc2ac
Compare
|
AppImage file: Nextcloud-PR-4556-a2cc2ace4a3f7f71e43eaa35dbd4b0071be778a5-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
|
The backport to stable-3.4 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than simply delivering notifications silently, this PR makes the desktop client ask for explicit permission from the user on launch if access has not been granted/denied: