Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot during the auto-update. #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
changed the title
mgallien
approved these changes
May 19, 2022
claucambra
approved these changes
May 19, 2022
… automatically when running from the updater. Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander
force-pushed
the
bugfix/autoupdate-do-not-reboot
branch
from
c33c044 to
e401428
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: Nextcloud-PR-4566-e40142847b0b66182904eea9c61c8483c6b59f96-x86_64.AppImage |
|
Thanks for adding this! I expected a prompt in the end to restart now, instead it just killed everything open and restarted. I've lost quite a bit progress there. Good to know you tackled the issue already. |
8 tasks
This was referenced Jul 18, 2022
|
/backport to stable-3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the annoying reboot with no prompt when running the installer via auto-updater. There is no way to show the popup in the passive MSI mode, so, Windows does the restart as if the user answered "Yes" to the popup. This PR removes such behavior, as a restart is not needed when updating since a shell integration is already installed and an .exe is not busy when updating to a newer version as it gets closed automatically.
Signed-off-by: alex-z blackslayer4@gmail.com