-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crashing when selecting user status and predefined statuses not appearing #4616
Conversation
bb0b299
to
77bc7cf
Compare
e69331e
to
a0c5647
Compare
8c797e0
to
ceeb255
Compare
Codecov Report
@@ Coverage Diff @@
## master #4616 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 138 138
Lines 17071 17071
=======================================
Hits 9632 9632
Misses 7439 7439 |
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
ceeb255
to
0658d72
Compare
Kudos, SonarCloud Quality Gate passed! |
AppImage file: Nextcloud-PR-4616-0658d7227ee3fea8ef8e3c5dc4da0e4cde59ecc3-x86_64.AppImage |
Previously, the signal handler for opening the user status selector dialog would try to trigger the loading of the selected user's user status connector for the user status selector model before the dialog had finished loading. This would cause the loading to never be triggered and the pointer to remain null, which, combined with the lack of a check for a null pointer, would cause a crash.
This PR fixes the user status connector loading behaviour to not be subject to this race condition, and adds checks for the null pointer in the user status selector model.
EDIT: upon testing this PR also fixes an issue where predefined statuses don't appear the first time the user status selector is invoked