Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure call notification stays on top of other windows #4659

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

claucambra
Copy link
Collaborator

Fixes #4523

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #4659 (0d26929) into master (af93a98) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4659      +/-   ##
==========================================
+ Coverage   56.42%   56.44%   +0.01%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
+ Hits         9633     9635       +2     
+ Misses       7438     7436       -2     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (-0.15%) ⬇️
src/libsync/discovery.cpp 84.86% <0.00%> (+0.29%) ⬆️

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/call-notification-on-top branch from 5b1b704 to 0d26929 Compare June 22, 2022 08:25
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4659-0d26929d41f61b7f4dc9f46eedfadc88e41afe35-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit fb4785c into master Jun 22, 2022
@claucambra claucambra deleted the bugfix/call-notification-on-top branch June 22, 2022 13:05
@mgallien mgallien added this to the 3.6.0 milestone Jun 24, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make call notification appear on top of other windows
4 participants