Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI. Use specific Craft revision. #4682

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Windows CI. Use specific Craft revision. #4682

merged 1 commit into from
Jun 29, 2022

Conversation

allexzander
Copy link
Contributor

Signed-off-by: alex-z blackslayer4@gmail.com

@mgallien mgallien force-pushed the bugfix/windows-ci-craft-revision branch from c9e5f0d to 46d3886 Compare June 29, 2022 07:46
@codecov
Copy link

codecov bot commented Jun 29, 2022 •
edited
Loading

Codecov Report

Merging #4682 (46d3886) into master (5657fc4) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 46d3886 differs from pull request most recent head 3630ae6. Consider uploading reports for the commit 3630ae6 to get more accurate results

@@           Coverage Diff           @@
##           master    #4682   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         138      138           
  Lines       17071    17069    -2     
=======================================
- Hits         9633     9632    -1     
+ Misses       7438     7437    -1
Impacted Files Coverage Δ
src/libsync/clientsideencryption.cpp 25.27% <0.00%> (ø)
src/libsync/propagatedownload.cpp 65.18% <0.00%> (-0.15%) ⬇️
src/libsync/networkjobs.cpp 50.07% <0.00%> (+0.14%) ⬆️

@allexzander allexzander force-pushed the bugfix/windows-ci-craft-revision branch from 46d3886 to c246c92 Compare June 29, 2022 17:29
@allexzander
Windows CI. Use forked Craft repository.
3630ae6 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/windows-ci-craft-revision branch from c246c92 to 3630ae6 Compare June 29, 2022 17:30
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4682-3630ae6ddd564e849387c62794afa2b5ebbe5ed9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@allexzander allexzander merged commit 24d5f52 into master Jun 29, 2022
@allexzander allexzander deleted the bugfix/windows-ci-craft-revision branch June 29, 2022 19:11
@mgallien mgallien added this to the 3.6.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien mgallien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @camilasan