Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad quote in CMakeLists PNG generation message #4700

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

claucambra
Copy link
Collaborator

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jul 5, 2022
@claucambra
Copy link
Collaborator Author

I am not sure if this is a real issue or just one from my syntax highlighter but with the quote before the log it highlights both lines as strings.

Screenshot 2022-07-05 at 11 57 59

Also get the CMake warning:

CMake Warning (dev) at src/gui/CMakeLists.txt:429:
  Syntax Warning in cmake code at column 56

  Argument not separated from preceding token by whitespace.
This warning is for project developers.  Use -Wno-dev to suppress it.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #4700 (9267e56) into master (b707aef) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 9267e56 differs from pull request most recent head f892d24. Consider uploading reports for the commit f892d24 to get more accurate results

@@            Coverage Diff             @@
##           master    #4700      +/-   ##
==========================================
- Coverage   56.51%   56.43%   -0.09%     
==========================================
  Files         138      138              
  Lines       17068    17068              
==========================================
- Hits         9646     9632      -14     
- Misses       7422     7436      +14     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.84% <0.00%> (-2.63%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 75.42% <0.00%> (-1.93%) ⬇️
src/libsync/syncengine.cpp 85.19% <0.00%> (-0.55%) ⬇️
src/libsync/discovery.cpp 84.86% <0.00%> (+0.29%) ⬆️
src/libsync/propagatedownload.cpp 65.18% <0.00%> (+1.03%) ⬆️

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@camilasan camilasan force-pushed the work/fix-png-gen-bug branch from 9267e56 to f892d24 Compare July 12, 2022 18:20
@camilasan
Copy link
Member

/backport to stable-3.5

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4700-f892d24717e9953ec1a1cb3b618638f0977daab4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 004d4e9 into master Jul 12, 2022
@claucambra claucambra deleted the work/fix-png-gen-bug branch July 12, 2022 18:59
@backportbot-nextcloud
Copy link

The backport to stable-3.5 failed. Please do this backport manually.

@claucambra
Copy link
Collaborator Author

Seems the PNG generation code which this is a fix for was never back ported hence the fail 🤨 best leave it as it is I think

@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants