-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad quote in CMakeLists PNG generation message #4700
Conversation
I am not sure if this is a real issue or just one from my syntax highlighter but with the quote before the log it highlights both lines as strings. Also get the CMake warning:
|
Codecov Report
@@ Coverage Diff @@
## master #4700 +/- ##
==========================================
- Coverage 56.51% 56.43% -0.09%
==========================================
Files 138 138
Lines 17068 17068
==========================================
- Hits 9646 9632 -14
- Misses 7422 7436 +14
|
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
9267e56
to
f892d24
Compare
/backport to stable-3.5 |
AppImage file: Nextcloud-PR-4700-f892d24717e9953ec1a1cb3b618638f0977daab4-x86_64.AppImage |
Kudos, SonarCloud Quality Gate passed! |
The backport to stable-3.5 failed. Please do this backport manually. |
Seems the PNG generation code which this is a fix for was never back ported hence the fail 🤨 best leave it as it is I think |
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com