Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop styling QML unified search items hierarchically, use global Style constants #4719

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Stop styling QML unified search items hierarchically, use global Style constants #4719

merged 1 commit into from
Jul 21, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jul 11, 2022 •
edited
Loading

This should make our QML code more maintainable:

  1. We can reduce the amount of duplicate code quite substantially
  2. QML items control their own styling, preventing situations where a styling element is changed in the item yet no visible change happens (because a parent element overrides the styling of the child item, which is unclear without a good grasp of the codebase)
  3. All of our styling values are kept in one place, where they affect all components equally

This PR also fixes some typos in our variables

@claucambra claucambra self-assigned this Jul 11, 2022
@camilasan
Copy link
Member

/backport to stable-3.5

@claucambra claucambra mentioned this pull request Jul 19, 2022
Merged
@claucambra
Stop styling QML unified search items hierarchically, use global Styl…
8d0df62 
…e constants

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/unifedsearch-styling branch from dc72b64 to 8d0df62 Compare July 21, 2022 13:38
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4719-8d0df62c499f3f432b79c8608fe2e50f6e14d2f2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit f8d9750 into master Jul 21, 2022
@claucambra claucambra deleted the bugfix/unifedsearch-styling branch July 21, 2022 14:04
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 21, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @camilasan @nextcloud-desktop-bot @allexzander @mgallien