Clicking on an activity list item for a file opens the local file if available

[claucambra]

If the activity refers to more than one item, it will open the containing folder (since activities with several files will contain files that are within the same folder)

Addresses a point in #4433 and fixes #4063

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[camilasan]

when do we show the file activity window?

[claucambra]

when do we show the file activity window?

When we want to see the file's activity from the file browser extension

IMO we should add context menus to the activity list items at some point, so we can interact with them in more than one way. I would say this is out of scope though

[camilasan]

IMO we should add context menus to the activity list items at some point, so we can interact with them in more than one way. I would say this is out of scope though

right click context menu? We do have a '...' menu but the way we list most actions right now with more buttons/links, the 'extra' menu never gets used or displayed. IMO showFileActivity should be there or in a button in the activities list.

[claucambra]

IMO we should add context menus to the activity list items at some point, so we can interact with them in more than one way. I would say this is out of scope though

right click context menu? We do have a '...' menu but the way we list most actions right now with more buttons/links, the 'extra' menu never gets used or displayed. IMO showFileActivity should be there or in a button in the activities list.

That would also work :)

[codecov]

Codecov Report

Merging #4748 (a2d00af) into master (9a84edf) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a2d00af differs from pull request most recent head 7891792. Consider uploading reports for the commit 7891792 to get more accurate results

@@            Coverage Diff             @@
##           master    #4748      +/-   ##
==========================================
- Coverage   56.80%   56.66%   -0.15%     
==========================================
  Files         138      138              
  Lines       17142    17142              
==========================================
- Hits         9738     9713      -25     
- Misses       7404     7429      +25     

Impacted Files	Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp	52.68% <0.00%> (-3.77%)	⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	85.09% <0.00%> (-2.36%)	⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	72.43% <0.00%> (-2.28%)	⬇️
src/libsync/syncengine.cpp	86.65% <0.00%> (-0.55%)	⬇️
src/libsync/propagatedownload.cpp	65.18% <0.00%> (+0.14%)	⬆️

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

60.0% Coverage
0.0% Duplication

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4748-789179214f1e0334d2b692c7bc361fe8f1b55680-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.