Replace unified search text field busy indicator with custom indicator

[claucambra]

Addresses a point in #4434

New spinner:

Screen.Recording.2022-07-18.at.17.21.14.mov

Old spinner:

Screen.Recording.2022-07-18.at.17.26.24.mov

[codecov]

Codecov Report

Merging #4753 (b1deb6c) into master (b37ca49) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4753      +/-   ##
==========================================
- Coverage   56.80%   56.67%   -0.13%     
==========================================
  Files         138      138              
  Lines       17142    17142              
==========================================
- Hits         9737     9715      -22     
- Misses       7405     7427      +22     

Impacted Files	Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp	52.68% <0.00%> (-3.77%)	⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp	85.09% <0.00%> (-2.36%)	⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp	72.89% <0.00%> (-1.37%)	⬇️
src/libsync/syncengine.cpp	86.65% <0.00%> (-0.55%)	⬇️

[mgallien]

I would have kept the BusyIndicator component and just style its contentItem to have it easier to understand that we just have a plain BusyIndicator but with a custom style

[claucambra]

I would have kept the BusyIndicator component and just style its contentItem to have it easier to understand that we just have a plain BusyIndicator but with a custom style

Sure -- I separated it into its own file and it is now a BusyIndicator

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4753-b1deb6cd1d43c99e554014007c66bc86dbb5eb6a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information