Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ubuntu Impish, add Kinetic #4758

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

ivaradi
Copy link
Contributor

@ivaradi ivaradi commented Jul 19, 2022

Support for Impish has ceased, so it is removed. Kinetic is the next Ubuntu release.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #4758 (3873c61) into master (a428d25) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
- Coverage   56.42%   56.40%   -0.02%     
==========================================
  Files         138      138              
  Lines       17069    17069              
==========================================
- Hits         9631     9628       -3     
- Misses       7438     7441       +3     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.56% <0.00%> (-0.30%) ⬇️

@ivaradi ivaradi requested review from mgallien and allexzander July 20, 2022 05:06
@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 20, 2022

/rebase

@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 20, 2022

/rebase

@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 20, 2022

Thanks for the approvals. How can we override the failings tests (none of them seem to have any relation to this change)?

@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 21, 2022

/rebase

@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 21, 2022

/rebase

@ivaradi ivaradi force-pushed the impish_kinetic branch 2 times, most recently from 47d4a02 to d75501d Compare July 22, 2022 03:51
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4758-3873c61c8516b0b842593e1a24817a69c7ceac8a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 384530a into nextcloud:master Jul 22, 2022
@ivaradi ivaradi deleted the impish_kinetic branch July 22, 2022 07:41
@ivaradi
Copy link
Contributor Author

ivaradi commented Jul 22, 2022

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants