Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to documentation #4792

Merged
merged 2 commits into from
Sep 10, 2022
Merged

Updated link to documentation #4792

merged 2 commits into from
Sep 10, 2022

Conversation

BMerz
Copy link
Contributor

@BMerz BMerz commented Jul 31, 2022

Link to 3.0 is not working

Signed-off-by: BMerz benedikt.merz@web.de

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4792 (5a3ae57) into master (a6867f9) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 5a3ae57 differs from pull request most recent head c3ff24f. Consider uploading reports for the commit c3ff24f to get more accurate results

@@            Coverage Diff             @@
##           master    #4792      +/-   ##
==========================================
+ Coverage   57.16%   57.23%   +0.06%     
==========================================
  Files         138      138              
  Lines       17135    17144       +9     
==========================================
+ Hits         9795     9812      +17     
+ Misses       7340     7332       -8     
Impacted Files Coverage Δ
src/libsync/owncloudpropagator.h 73.28% <0.00%> (-1.16%) ⬇️
src/libsync/bulkpropagatorjob.cpp 72.14% <0.00%> (-0.16%) ⬇️
src/libsync/owncloudpropagator.cpp 86.00% <0.00%> (-0.03%) ⬇️
src/libsync/syncengine.cpp 87.22% <0.00%> (+0.02%) ⬆️
src/libsync/propagatedownload.cpp 65.33% <0.00%> (+0.14%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.71% <0.00%> (+0.51%) ⬆️
src/libsync/propagateremotemkdir.cpp 65.24% <0.00%> (+0.70%) ⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 87.45% <0.00%> (+1.03%) ⬆️
src/libsync/propagateuploadng.cpp 83.89% <0.00%> (+1.49%) ⬆️

doc/README.md Outdated Show resolved Hide resolved
@camilasan
Copy link
Member

Thanks for this fix @BMerz.
Please, remove the merge commit.

@BMerz
Copy link
Contributor Author

BMerz commented Aug 9, 2022

Thanks for this fix @BMerz. Please, remove the merge commit.

Did a rebase. Hope that was, what you requested. If not, please guide me ...

@BMerz BMerz requested a review from camilasan August 14, 2022 12:03
@camilasan
Copy link
Member

/rebase

Link to 3.0 is not working

Signed-off-by: BMerz <benedikt.merz@web.de>
Signed-off-by: BMerz <benedikt.merz@web.de>
@mgallien mgallien merged commit d91415e into nextcloud:master Sep 10, 2022
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4792-c3ff24facab30ac9e49c12d792ae0fb91630818f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants