Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move URI scheme variable from Nextcloud.cmake to root CMakeListsts. #4815

Merged

Conversation

allexzander
Copy link
Contributor

Signed-off-by: allexzander blackslayer4@gmail.com

Signed-off-by: allexzander <blackslayer4@gmail.com>
@allexzander allexzander changed the title Move URI scheme variable from Nextcloud.cmake to root CmakeListst. Move URI scheme variable from Nextcloud.cmake to root CmakeListsts. Aug 4, 2022
@allexzander allexzander changed the title Move URI scheme variable from Nextcloud.cmake to root CmakeListsts. Move URI scheme variable from Nextcloud.cmake to root CMakeListsts. Aug 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #4815 (9270d40) into master (ba16c4d) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4815      +/-   ##
==========================================
+ Coverage   56.67%   56.81%   +0.14%     
==========================================
  Files         138      138              
  Lines       17143    17143              
==========================================
+ Hits         9715     9739      +24     
+ Misses       7428     7404      -24     
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.18% <0.00%> (ø)
src/libsync/syncengine.cpp 87.20% <0.00%> (+0.54%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.71% <0.00%> (+1.82%) ⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 87.45% <0.00%> (+2.35%) ⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp 56.45% <0.00%> (+3.76%) ⬆️

@allexzander allexzander merged commit cc548ad into master Aug 4, 2022
@allexzander allexzander deleted the bugfix/move-uri-scheme-from-nextcloudcmake-to-root-cmake branch August 4, 2022 11:28
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4815-9270d401e89f9d62fcb9165be90178577911a371-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants