Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix greek translation for application name in menu #4827

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Fix greek translation for application name in menu #4827

merged 1 commit into from
Aug 9, 2022

Conversation

gapan
Copy link
Contributor

@gapan gapan commented Aug 6, 2022

Somebody had translated the @APPLICATION_NAME@ macro to greek and so if
the user's locale was set to greek (el_GR.utf8) the menu entry would be
messed up. Apparently this was inherited from owncloud like that. This
commit changes it back to @APPLICATION_NAME@.

Signed-off-by: George Vlahavas vlahavas@gmail.com

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #4827 (41079fb) into master (a4c8a1d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4827      +/-   ##
==========================================
- Coverage   57.22%   57.21%   -0.02%     
==========================================
  Files         138      138              
  Lines       17144    17144              
==========================================
- Hits         9811     9809       -2     
- Misses       7333     7335       +2     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.25% <0.00%> (-0.46%) ⬇️

@camilasan
Copy link
Member

/rebase

1 similar comment
@camilasan
Copy link
Member

/rebase

Somebody had translated the @APPLICATION_NAME@ macro to greek and so if
the user's locale was set to greek (el_GR.utf8) the menu entry would be
messed up. Apparently this was inherited from owncloud like that. This
commit changes it back to @APPLICATION_NAME@.

Signed-off-by: George Vlahavas <vlahavas@gmail.com>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4827-41079fb52e0926a38a2bb71efc1eda0b300c129d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit c7567b7 into nextcloud:master Aug 9, 2022
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants