Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the 'Cancel' button of the user status selector getting squashed #4843

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Prevent the 'Cancel' button of the user status selector getting squashed #4843

merged 1 commit into from
Aug 17, 2022

Conversation

claucambra
Copy link
Collaborator

This PR:

Screenshot_20220810_175713

Master:

Screenshot_20220810_175937

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited
Loading

Codecov Report

Merging #4843 (6f513b7) into master (622462f) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6f513b7 differs from pull request most recent head 27f28d7. Consider uploading reports for the commit 27f28d7 to get more accurate results

@@           Coverage Diff           @@
##           master    #4843   +/-   ##
=======================================
  Coverage   57.21%   57.22%           
=======================================
  Files         138      138           
  Lines       17144    17144           
=======================================
+ Hits         9809     9810    +1     
+ Misses       7335     7334    -1
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 65.33% <0.00%> (+0.14%) ⬆️

@claucambra
Prevent the 'Cancel' button of the user status selector getting squashed
27f28d7 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/user-status-selector-cancel-button branch from 6f513b7 to 27f28d7 Compare August 17, 2022 19:08
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4843-27f28d781e93fde6f77222f049dcdc09101823d0-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit b280dc2 into master Aug 17, 2022
@claucambra claucambra deleted the bugfix/user-status-selector-cancel-button branch August 17, 2022 19:40
@mgallien mgallien added this to the 3.6.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @nextcloud-desktop-bot @camilasan @allexzander @mgallien