Fix add account window text clipping, enlarge text #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
requested review from
mgallien,
camilasan,
jancborchardt and
allexzander
Codecov Report
@@ Coverage Diff @@
## master #4910 +/- ##
==========================================
- Coverage 57.21% 57.17% -0.05%
==========================================
Files 138 138
Lines 17136 17136
==========================================
- Hits 9805 9798 -7
- Misses 7331 7338 +7
|
mgallien
reviewed
Sep 9, 2022
claucambra
force-pushed
the
bugfix/add-account-text
branch
from
ca01a2c to
ca1a34c
Compare
mgallien
approved these changes
Sep 10, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
mgallien
force-pushed
the
bugfix/add-account-text
branch
from
ca1a34c to
6619805
Compare
|
AppImage file: nextcloud-PR-4910-66198055d31946158efeef9b564ab13e790af0ac-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
|
/backport to stable-3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enlargement of the text partially addresses #4896
Fixing the text layouting should make it easier for translators to change the text without the text view being broken. It also lets us use larger lettering without having to be careful not to break the text view
Screen.Recording.2022-09-07.at.16.48.04.mov
Below is master:
Screen.Recording.2022-09-07.at.16.53.41.mov
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com