Make account setup wizard's adjustWizardSize resize to current page size instead of largest wizard page #4911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
requested review from
mgallien,
camilasan,
jancborchardt and
allexzander
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4911 +/- ##
=======================================
Coverage 57.20% 57.20%
=======================================
Files 138 138
Lines 17138 17138
=======================================
Hits 9804 9804
Misses 7334 7334
|
|
Nice! The height could still be a bit less @claucambra? |
I can't make it any smaller without risking breakages at different font sizes/DPIs as this seems to be the implicit height of the internal component... :( |
mgallien
approved these changes
Sep 13, 2022
…ize instead of largest wizard page Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/account-wizard-size
branch
from
5e94b4a to
14303d0
Compare
|
AppImage file: nextcloud-PR-4911-14303d0eb60063fba8b9563d95402d82f925a15f-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the account setup wizard from being overly large for its first view. It can resize as needed as the pages are progressed
Compared to master:
Addresses point 2 in #4896
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com