Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix low-resolution file changed overlay icons in activities #4930

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Fix low-resolution file changed overlay icons in activities #4930

merged 1 commit into from
Sep 13, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Sep 13, 2022 •
edited
Loading

Now:

Screenshot 2022-09-13 at 18 29 55

Before:

Screenshot 2022-09-13 at 18 31 01

Fixes #4892

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Sep 13, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #4930 (e225172) into master (89564cc) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head e225172 differs from pull request most recent head 4c9e087. Consider uploading reports for the commit 4c9e087 to get more accurate results

@@            Coverage Diff             @@
##           master    #4930      +/-   ##
==========================================
- Coverage   57.18%   57.06%   -0.13%     
==========================================
  Files         138      138              
  Lines       17138    17138              
==========================================
- Hits         9800     9779      -21     
- Misses       7338     7359      +21
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.95% <0.00%> (-2.47%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.83% <0.00%> (-1.37%) ⬇️
src/libsync/syncengine.cpp 86.65% <0.00%> (-0.55%) ⬇️
src/libsync/propagatedownload.cpp 65.03% <0.00%> (+0.14%) ⬆️

@claucambra @mgallien
Fix low-resolution file changed overlay icons in activities
4c9e087 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/pixelated-file-changed-overlay-icon branch from e225172 to 4c9e087 Compare September 13, 2022 16:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 20c5f8e into master Sep 13, 2022
@claucambra claucambra deleted the bugfix/pixelated-file-changed-overlay-icon branch September 13, 2022 17:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4930-4c9e0873a34b78a333ea70330d5c79098a8f482b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 14, 2022
Merged
@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
@claucambra claucambra mentioned this pull request Oct 10, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Overlay "changed" icons in list of activities in main dialog have wrong resolution
3 participants
@claucambra @nextcloud-desktop-bot @mgallien