Add a QSortFilterProxyModel-based SortedActivityListModel #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
force-pushed
the
bugfix/sorted-activity-model
branch
2 times, most recently
from
c88d98b to
17fcce7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4933 +/- ##
=======================================
Coverage 57.12% 57.12%
=======================================
Files 138 138
Lines 17232 17232
=======================================
+ Hits 9843 9844 +1
+ Misses 7389 7388 -1
|
allexzander
approved these changes
Sep 26, 2022
claucambra
force-pushed
the
bugfix/sorted-activity-model
branch
4 times, most recently
from
47f2ef5 to
2691853
Compare
…ctivities Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
…ivitylistmodel Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/sorted-activity-model
branch
from
2691853 to
e721b03
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-4933-e721b03106cc606372e657cf45e8fb8eb3e86e84-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retains the benefits of #4736 while obviating the need for much of the error-prone sorting currently done in the ActivityListModel.
The results in a far simpler ActivityListModel, and thanks to the QSortFilterProxyModel, a far less complicated and error-prone sorting method. The SortedActivityListModel will also allow us to more easily modify sorting details in the future.