-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate certificate for E2EE against private key #4949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
September 17, 2022 13:06
617fc81
to
49edd9b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4949 +/- ##
==========================================
- Coverage 57.32% 57.13% -0.20%
==========================================
Files 138 138
Lines 17426 17444 +18
==========================================
- Hits 9990 9967 -23
- Misses 7436 7477 +41
|
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
2 times, most recently
from
September 19, 2022 07:44
1d9a22e
to
49d4264
Compare
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
2 times, most recently
from
October 5, 2022 07:25
dbb9926
to
839b018
Compare
allexzander
reviewed
Oct 5, 2022
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
October 5, 2022 12:01
839b018
to
90b9be3
Compare
claucambra
reviewed
Oct 5, 2022
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
October 5, 2022 13:41
90b9be3
to
9b33bf8
Compare
allexzander
reviewed
Oct 5, 2022
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
October 12, 2022 10:12
b33532f
to
f80ff25
Compare
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
October 12, 2022 11:51
f80ff25
to
cf2f412
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/checkCertAgainstPrivateKey
branch
from
October 24, 2022 08:25
cf2f412
to
b9d4e70
Compare
SonarCloud Quality Gate failed. |
AppImage file: nextcloud-PR-4949-b9d4e7045ea06ebf496d712036a7a07acdee04ba-x86_64.AppImage |
claucambra
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com