Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate certificate for E2EE against private key #4949

Merged
merged 7 commits into from
Oct 24, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from 617fc81 to 49edd9b Compare September 17, 2022 13:06
@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #4949 (b9d4e70) into master (8ccb563) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4949      +/-   ##
==========================================
- Coverage   57.32%   57.13%   -0.20%     
==========================================
  Files         138      138              
  Lines       17426    17444      +18     
==========================================
- Hits         9990     9967      -23     
- Misses       7436     7477      +41     
Impacted Files Coverage Δ
src/libsync/clientsideencryption.cpp 26.33% <0.00%> (-0.48%) ⬇️
src/libsync/clientsideencryption.h 38.46% <ø> (ø)
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.00% <0.00%> (-2.38%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (-1.60%) ⬇️
src/libsync/syncengine.cpp 83.78% <0.00%> (-0.46%) ⬇️

@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch 2 times, most recently from 1d9a22e to 49d4264 Compare September 19, 2022 07:44
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch 2 times, most recently from dbb9926 to 839b018 Compare October 5, 2022 07:25
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from 839b018 to 90b9be3 Compare October 5, 2022 12:01
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from 90b9be3 to 9b33bf8 Compare October 5, 2022 13:41
src/libsync/clientsideencryption.cpp Outdated Show resolved Hide resolved
src/libsync/clientsideencryption.cpp Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from b33532f to f80ff25 Compare October 12, 2022 10:12
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from f80ff25 to cf2f412 Compare October 12, 2022 11:51
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/checkCertAgainstPrivateKey branch from cf2f412 to b9d4e70 Compare October 24, 2022 08:25
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4949-b9d4e7045ea06ebf496d712036a7a07acdee04ba-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit f1c3cee into master Oct 24, 2022
@mgallien mgallien deleted the bugfix/checkCertAgainstPrivateKey branch October 24, 2022 13:39
@mgallien mgallien added this to the 3.7.0 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants