Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dismiss button: display it whenever possible. #4989

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Fix the dismiss button: display it whenever possible. #4989

merged 3 commits into from
Oct 17, 2022

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Sep 29, 2022 •
edited
Loading

dismiss-gray1
dismiss-gray2

@camilasan camilasan changed the title Fix the dimiss button: display it whenever is possible. Fix the dismiss button: display it whenever is possible. Sep 29, 2022
@camilasan camilasan force-pushed the bugfix/dismiss branch 2 times, most recently from f7e2285 to a523379 Compare September 29, 2022 20:08
@camilasan camilasan changed the title Fix the dismiss button: display it whenever is possible. Fix the dismiss button: display it whenever possible. Sep 29, 2022
@camilasan camilasan marked this pull request as draft September 29, 2022 20:09
@codecov
Copy link

codecov bot commented Sep 29, 2022 •
edited
Loading

Codecov Report

Merging #4989 (2720bff) into master (f9949ee) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 2720bff differs from pull request most recent head f8b3ad8. Consider uploading reports for the commit f8b3ad8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4989      +/-   ##
==========================================
- Coverage   57.37%   57.23%   -0.15%     
==========================================
  Files         138      138              
  Lines       17418    17391      -27     
==========================================
- Hits         9993     9953      -40     
- Misses       7425     7438      +13
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.00% <0.00%> (-2.38%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (-1.82%) ⬇️
src/libsync/propagateremotemkdir.cpp 65.03% <0.00%> (-0.70%) ⬇️
src/libsync/syncengine.cpp 83.78% <0.00%> (-0.46%) ⬇️
src/libsync/discovery.cpp 83.76% <0.00%> (-0.29%) ⬇️
src/libsync/networkjobs.cpp 50.00% <0.00%> (-0.29%) ⬇️
src/libsync/networkjobs.h 5.00% <0.00%> (+0.23%) ⬆️
src/libsync/filesystem.cpp 76.34% <0.00%> (+3.22%) ⬆️

nimishavijay
nimishavijay reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment •
edited by camilasan
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! Much better now! Only 2 points of feedback:

  • Could there be better hover feedback? For eg. a grey circle around the x icon?
  • The alignment seems a bit off. Is it possible to move it a few pixels to the top so that it is top aligned with the text?

@camilasan
Copy link
Member Author

@nimishavijay I did now like the share button:

feedback

wdyt?

@nimishavijay
Copy link
Member

really nice. however it seems really present for a dismiss button, so we could possibly go with a gray background like the 3 dot menu in the file details PR? Other than that it looks great :)

@camilasan camilasan marked this pull request as ready for review October 4, 2022 11:15
@camilasan
Copy link
Member Author

/rebase

@camilasan
Copy link
Member Author

/backport to stable-3.6

@camilasan
Copy link
Member Author

/rebase

@camilasan
Copy link
Member Author

/rebase

@camilasan
Copy link
Member Author

/rebase

Fix the dismiss button: display it whenever possible.
0624bec 
Signed-off-by: Camila <hello@camila.codes>
Camila added 2 commits October 17, 2022 11:29
The dismiss button is now a CustomButton component.
b55d71d 
Signed-off-by: Camila <hello@camila.codes>
Update tests.
f8b3ad8 
Signed-off-by: Camila <hello@camila.codes>
@camilasan camilasan merged commit 3c285b4 into master Oct 17, 2022
@camilasan camilasan deleted the bugfix/dismiss branch October 17, 2022 11:42
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 17, 2022
Closed
1 task
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4989-f8b3ad88523972e2632971cbc637a856b36b7ec7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan mentioned this pull request Oct 18, 2022
Merged
@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay left review comments

@claucambra claucambra claucambra approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@camilasan @nimishavijay @nextcloud-desktop-bot @claucambra @mgallien