Ci/use no discard #4992
Merged
Ci/use no discard #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4992 +/- ##
==========================================
- Coverage 57.12% 57.00% -0.13%
==========================================
Files 138 138
Lines 17228 17221 -7
==========================================
- Hits 9842 9817 -25
- Misses 7386 7404 +18
|
mgallien
force-pushed
the
ci/useNoDiscard
branch
from
fea624a to
875c5bc
Compare
claucambra
approved these changes
Oct 1, 2022
mgallien
force-pushed
the
ci/useNoDiscard
branch
2 times, most recently
from
ed80d62 to
fbfd2ac
Compare
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
ran run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix under linux with most part of our code covered Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
ci/useNoDiscard
branch
from
fbfd2ac to
565a5f0
Compare
|
AppImage file: nextcloud-PR-4992-565a5f099916427ccbfa5f25dc6e8bc3e65ebfc7-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.