alway use constexpr for all text constants #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Oct 1, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4996 +/- ##
==========================================
+ Coverage 57.13% 57.15% +0.01%
==========================================
Files 138 138
Lines 17221 17221
==========================================
+ Hits 9839 9842 +3
+ Misses 7382 7379 -3
|
allexzander
approved these changes
Oct 2, 2022
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
cleanConfigFileConstants
branch
from
0ac23af to
9f1b6c2
Compare
|
SonarCloud Quality Gate failed.
|
|
AppImage file: nextcloud-PR-4996-0b4128eede5041778d51429f473deedb77e9cdc5-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com