Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "pretty user name"-related strings, display in webflow credentials #5013

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Improve "pretty user name"-related strings, display in webflow credentials #5013

merged 5 commits into from
Oct 19, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Oct 6, 2022 •
edited
Loading

With fix Without fix
image Screenshot_20221006_164418

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Oct 6, 2022
mgallien
mgallien requested changes Oct 6, 2022
View reviewed changes
src/gui/creds/webflowcredentials.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/webflow-user-strings branch from 35f3d46 to 78184f0 Compare October 6, 2022 17:54
@claucambra claucambra changed the title Improve user-related strings in webflow credentials Improve "pretty user name"-related strings, display in webflow credentials Oct 6, 2022
@claucambra claucambra requested a review from mgallien October 6, 2022 18:01
@codecov
Copy link

codecov bot commented Oct 6, 2022 •
edited
Loading

Codecov Report

Merging #5013 (0b9267c) into master (4286099) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

❗ Current head 0b9267c differs from pull request most recent head 0bce174. Consider uploading reports for the commit 0bce174 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5013      +/-   ##
==========================================
- Coverage   57.35%   57.30%   -0.05%     
==========================================
  Files         138      138              
  Lines       17391    17402      +11     
==========================================
- Hits         9974     9972       -2     
- Misses       7417     7430      +13
Impacted Files Coverage Δ
src/libsync/account.h 29.41% <ø> (-3.93%) ⬇️
src/libsync/account.cpp 38.04% <25.00%> (+0.04%) ⬆️
src/libsync/syncengine.cpp 83.33% <0.00%> (-0.91%) ⬇️
src/libsync/discoveryphase.cpp 72.34% <0.00%> (-0.84%) ⬇️
src/libsync/discovery.cpp 83.44% <0.00%> (-0.33%) ⬇️
src/libsync/propagatedownload.cpp 64.75% <0.00%> (+0.14%) ⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 85.77% <0.00%> (+0.39%) ⬆️

mgallien
mgallien reviewed Oct 10, 2022
View reviewed changes
src/gui/accountmanager.cpp Outdated Show resolved Hide resolved
src/gui/accountsettings.cpp Outdated Show resolved Hide resolved
@claucambra claucambra changed the title Improve "pretty user name"-related strings, display in webflow credentials Improve "pretty user name"-related strings, display in webflow credentials, modernise surrounding code Oct 10, 2022
@claucambra claucambra requested a review from mgallien October 10, 2022 10:38
@claucambra claucambra force-pushed the bugfix/webflow-user-strings branch from 77dbc15 to 0b9267c Compare October 10, 2022 10:57
@claucambra claucambra changed the title Improve "pretty user name"-related strings, display in webflow credentials, modernise surrounding code Improve "pretty user name"-related strings, display in webflow credentials Oct 10, 2022
@mgallien mgallien force-pushed the bugfix/webflow-user-strings branch from 0b9267c to 82be953 Compare October 19, 2022 09:39
@claucambra
Improve user-related strings in webflow credentials
25ca698 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Save account's display name in config
29afd9d 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display the user's 'pretty' name in the webflow credentials
3596270 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Use prettyName more widely, instead of duplicating fallback string code
8de5b0f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Change unchanging settings strings into constexpr auto in accountmanager
0bce174 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/webflow-user-strings branch from 82be953 to 0bce174 Compare October 19, 2022 11:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5013-0bce17425b5f50fdad871cf1277a058a816b39d2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit f2f7d82 into master Oct 19, 2022
@claucambra claucambra deleted the bugfix/webflow-user-strings branch October 19, 2022 12:04
@mgallien mgallien added this to the 3.7.0 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien